Skip to content

cdooms/charlotte

Repository files navigation

Charlotte

Visual and functional remarks (Round 1):

  • fix scss linting errors, I readded it to the grunt tasks. (now you can see where you made mistakes) this task only runs on grunt, not grunt watch
  • Input field password image
  • Hover color on buttons example
  • Text Area placeholder image
  • Use al the space you have image
  • h5 should be replaced with label with id that referes to input image
  • always keep in mind where much text may show up, GOOD JOB image
  • when you deal with buttons, you should avoid the button tag :D, unless it is for a form submit or something that can be visualized as a button image use tags instead because they do not have a default look in browsers. Buttons are mostly used only in form contexts
  • city.png should be a background image
  • when you deal with rounded corners on images, you should use border radius on a rect image image
  • you have styled the li and the a tag within that li image
  • when you add icons they should be centered image
  • 2014 should be text
  • line bug image
  • remove grid background helper
  • add box-shadow image
  • no hover state image

Things you can do to bump up the performance and make it more functional

  • use custom fonts image
  • use svg or icon font for all the icons to minimize requests
  • make it responsive
  • use animation on hovers
  • integrate video
  • integrate graphic library chartjs
  • integrate dropdown drop down
  • make 2014 the actual year so that it updates when we are in 2016, with javascript.
  • integrate tag component image
  • integrate real tweets with twitter api of hugh jackman image
  • Xbrowser ie8 :D

keep up the good work !

When you develop one of the above points you should use git branching, after a branch/feature is complete I will do a code review on it. Maybe you should solve all the issues in round 1 in a branch round-1-issues

About

persoonlijke opdrachtjes one-agency

Resources

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published