Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate favorites status in menu #26

Closed
CDrummond opened this issue Nov 27, 2018 · 0 comments
Closed

Indicate favorites status in menu #26

CDrummond opened this issue Nov 27, 2018 · 0 comments
Labels
enhancement New feature or request low priority

Comments

@CDrummond
Copy link
Owner

CDrummond commented Nov 27, 2018

In the browse view, the menu always has "Add to favorites", even if item is already in favorites. Perhaps before (or whilst?) showing the menu, a check should be performed. If the item is in favorites, change it to a remove from favorites entry. The favorite status should be cached with the item to save repeated lookups.

This should be handled after #23. Using CometD will allow material to receive notifications when favourites have changed.

@CDrummond CDrummond added enhancement New feature or request low priority labels Nov 27, 2018
CDrummond added a commit that referenced this issue Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority
Projects
None yet
Development

No branches or pull requests

1 participant