Make write call save #117
Merged
Make write call save #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManonMarchand
force-pushed
the
make-write-call-save
branch
from
ae41dbb
to
1008495
Compare
this add the fits_keywords argument to the new save function so that the functionnalities are maintained. This PR also adds a test_abstract_moc file that tests the save method for all moc types.
ManonMarchand
force-pushed
the
make-write-call-save
branch
from
3046f84
to
2b6dd45
Compare
ManonMarchand
force-pushed
the
make-write-call-save
branch
from
4321350
to
2255310
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What the PR does:
(I mixed my commits so this PR does way too much)
n_cellsmethod to each MOC typesavetestsmocpy.stmoc.STMOC.from_spatial_coveragesnow also accepts non iterable objects (prevents from having to wrap a single moc in a list each time it's used)max_norderargument that was introduced in a former versionwritefunctioncallsave internally [Make deprecated write call save #114 ]fits_keywordsto be added to the header (was needed to keep all ofwritefunctionalities)