-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make deprecated write call save #114
Comments
Fwiw, in general you cannot expect attributes to be ordered in a JSON document, From my point-of-view the problem here comes from the fact that the Java MOC implementation requires (That said, I agree to call |
- add the `n_cells` method to each MOC type - adds a new file to test abstract moc and remove duplicated `save` tests - the `mocpy.stmoc.STMOC.from_spatial_coverages` now also accepts non iterable objects (prevents from having to wrap a single moc in a list each time it's used) - fixed a warning in the notebooks because of `max_norder` argument that was introduced in a former version - makes the `write` function `call` save internally [#114 ] - save now accepts `fits_keywords` to be added to the header (was needed to keep all of `write` functionalities)
The deprecated
write
method does not sort the MOC while the newsave
does. This causes compatibility issues with aladin desktop. Let's fix it for now before removing the deprecated function (likely in v1)The text was updated successfully, but these errors were encountered: