Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the indicator value 'hard-stop' to 'critical' (fixes #340) #371

Merged
merged 2 commits into from
Aug 2, 2018
Merged

Rename the indicator value 'hard-stop' to 'critical' (fixes #340) #371

merged 2 commits into from
Aug 2, 2018

Conversation

kpshek
Copy link
Contributor

@kpshek kpshek commented Aug 1, 2018

Fixes #340

@kpshek kpshek added the substantive This issue is a substantive change per HL7's ballot rules label Aug 1, 2018
@kpshek kpshek temporarily deployed to cds-hooks-docs-pr-371 August 1, 2018 04:20 Inactive
brettmarquard
brettmarquard approved these changes Aug 1, 2018
View reviewed changes
Copy link
Collaborator

@brettmarquard brettmarquard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@isaacvetter
Copy link
Member

I like everything about this change. That issue submitter is a bright guy.

@kpshek kpshek merged commit e71c566 into master Aug 2, 2018
@kpshek kpshek deleted the issue/340-rename-hard-stop-to-critical branch August 2, 2018 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaacvetter isaacvetter isaacvetter approved these changes

@brettmarquard brettmarquard brettmarquard approved these changes

@brynrhodes brynrhodes Awaiting requested review from brynrhodes

Assignees
No one assigned
Labels
substantive This issue is a substantive change per HL7's ballot rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpshek @isaacvetter @brettmarquard