Now generating the expiry via javascript and showing local time #77
Conversation
|
This pull request introduces 1 alert when merging f00935e into f3e254e - view on LGTM.com new alerts:
|
| <script type="text/javascript"> | ||
| document.addEventListener('DOMContentLoaded', function(){ | ||
| const expiry = new Date().addHours(24); | ||
| document.getElementById('expiry').innerHTML = expiry.toLocaleString('{{ LANGUAGE_CODE }}'); | ||
| }, false); | ||
| </script> |
There was a problem hiding this comment.
Nice, this looks clean.
We'd like to keep a similar format as we had before though (I know vanilla JS date formatting is awful), so I'm not sure what's the cheapest solution here.
There was a problem hiding this comment.
That was my first reflex, but the latest version of the (official) CDN for date-fns was 1.9 (4 years ago). unpkg does seem to have a good up to date version (2.14) so I will make the switch. Thanks!
|
Heyo, we want more control over the format of the "expires" string. What we have now in Figma is pretty different than we get here, so maybe bring in date-fns as a CDN dependency or maybe there's a better way to do this? I think we should stay away from npm if it's only for one JS dependency.
|
|
After talking with Paul, we had too many issues using date-fns without using NPM. So here is the updated pull request with the smallest version of momentjs, delivered by the cloudfare DNS. English |
pcraig3
force-pushed
the
bugfix-code-expiry-local-time
branch
from
e577634
to
32dc679
Compare
The logic was making our template really complex, so pull it into a separate includes file. Did it progressively-enhanced, so if Javascript fails to run, it will still show the time and date in EDT.
pcraig3
force-pushed
the
bugfix-code-expiry-local-time
branch
from
32dc679
to
8493f3e
Compare
Now generating the expiry time in javascript and adding 24 h. Also displaying the local time in both french and english format.