Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create design-system.alpha.canada.ca.tf #317

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

ethanWallace
Copy link
Contributor

Summary | Résumé

Create design-system.alpha.canada.ca.tf to add CNAME record for design-system.alpha.canada.ca/systeme-design.alpha.canada.ca.

@github-actions
Copy link

DNS

✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 2 to add, 0 to change, 0 to destroy
Show summary
CHANGE NAME
add aws_route53_record.design-system-alpha-canada-ca-CNAME
aws_route53_record.systeme-design-alpha-canada-ca-CNAME
Show plan
Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # aws_route53_record.design-system-alpha-canada-ca-CNAME will be created
  + resource "aws_route53_record" "design-system-alpha-canada-ca-CNAME" {
      + allow_overwrite = (known after apply)
      + fqdn            = (known after apply)
      + id              = (known after apply)
      + name            = "design-system.alpha.canada.ca"
      + records         = [
          + "cds-design-snc.netlify.app",
        ]
      + ttl             = 300
      + type            = "CNAME"
      + zone_id         = "Z33C47YI9EN8XL"
    }

  # aws_route53_record.systeme-design-alpha-canada-ca-CNAME will be created
  + resource "aws_route53_record" "systeme-design-alpha-canada-ca-CNAME" {
      + allow_overwrite = (known after apply)
      + fqdn            = (known after apply)
      + id              = (known after apply)
      + name            = "systeme-design.alpha.canada.ca"
      + records         = [
          + "cds-design-snc.netlify.app",
        ]
      + ttl             = 300
      + type            = "CNAME"
      + zone_id         = "Z33C47YI9EN8XL"
    }

Plan: 2 to add, 0 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"
Show Conftest results
WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.alpha-canada-ca-public"]
WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.cds-snc-ca-public"]
WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.notification-canada-ca-public"]

20 tests, 17 passed, 3 warnings, 0 failures, 0 exceptions

Copy link
Member

@patheard patheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good!

Just do double-check are you planning to remove this record after the new one goes live or did you want to leave both active?
https://github.com/cds-snc/dns/blob/bcbe790399508681f33635e6d2fb137f31c32cc9/terraform/design.canada.ca.tf

@ethanWallace
Copy link
Contributor Author

That one will be staying active for now. Might remove it in the future but more discussions need to be had before that can happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants