Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add @Outputs to angular wrapper components #529

Merged
merged 2 commits into from
May 17, 2024

Conversation

ethanWallace
Copy link
Collaborator

@ethanWallace ethanWallace commented May 15, 2024

Summary | Résumé

Using a modified local version of @stencil/angular-output-target generate angular components that feature the events emitted in outputs.

Part of

Copy link
Collaborator

@daine daine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking about this a bit more: I'd like us to go over the decision record together before this gets merged onto main 🤔

Copy link
Collaborator

@melaniebmn melaniebmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@daine daine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, approved! I added our decision record on the ticket itself for visibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants