Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update logic check on when to run upload-to-cdn #565

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

daine
Copy link
Collaborator

@daine daine commented Jun 20, 2024

Summary | Résumé

This is an update to the previous PR #563:

To make sure the github.event.workflow_run.conclusion check doesn't fail, add an additional check that the event name is workflow_run.

I tested this gh action on my own repo

Both ran successfully

Copy link
Collaborator

@ethanWallace ethanWallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@melaniebmn melaniebmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daine daine merged commit 35e1604 into main Jun 20, 2024
3 checks passed
@daine daine deleted the refactor/update-logic-check branch June 20, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants