Skip to content

Commit

Permalink
Revert "Exclude content length errors from recipient_error prop (#290)…
Browse files Browse the repository at this point in the history
…" (#292)

This reverts commit 4e204b1.
  • Loading branch information
whabanks committed Apr 26, 2024
1 parent 4e204b1 commit cd287cf
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/actions/waffles/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
docopt==0.6.2
Flask==2.3.3
markupsafe==2.1.4
git+https://github.com/cds-snc/notifier-utils.git@52.1.10#egg=notifications-utils
git+https://github.com/cds-snc/notifier-utils.git@52.1.9#egg=notifications-utils
8 changes: 0 additions & 8 deletions notifications_utils/columns.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,6 @@ def __init__(
else ["phone number", "numéro de téléphone", "to"]
)

# This won't mark a row as too long in all cases. A message can be too long if
# placeholder content is added by a user that exceeds the limit when added to
# the template's content.
if template:
template.values = row_dict
self.message_too_long = template.is_message_too_long()
Expand Down Expand Up @@ -147,9 +144,4 @@ def __eq__(self, other):

@property
def recipient_error(self):
# TODO: This is a bandaid solution. We need to establish why we are calling this Cell property on
# Cells that do not represent a recipient value.
if self.error is not None and "Some messages may be too long due to custom content." in self.error:
return False

return self.error not in {None, self.missing_field_error}
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ include = '(notifications_utils|tests)/.*\.pyi?$'

[tool.poetry]
name = "notifications-utils"
version = "52.1.10"
version = "52.1.9"
description = "Shared python code for Notification - Provides logging utils etc."
authors = ["Canadian Digital Service"]
license = "MIT license"
Expand Down

0 comments on commit cd287cf

Please sign in to comment.