Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Exclude content length errors from recipient_error prop" #292

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

whabanks
Copy link
Contributor

Reverts #290

We encountered a couple issues where SMS limit checking that was a part of this PR, and #278, was applying to bulk emails when it should only be applicable to bulk SMS.

@jzbahrai jzbahrai merged commit cd287cf into main Apr 26, 2024
4 checks passed
@jzbahrai jzbahrai deleted the revert-290-fix/recipient-error-matching branch April 26, 2024 13:44
whabanks added a commit that referenced this pull request May 3, 2024
@whabanks whabanks mentioned this pull request May 3, 2024
5 tasks
whabanks added a commit that referenced this pull request May 21, 2024
* Reinstate PR #278 which added additional length checks to bulk SMS sends (#293)"

This reverts commit 0146718.

* Reinstate "Exclude content length errors from recipient_error prop (#290)" (#292)"

This reverts commit cd287cf.

* Remove unused parameter

* Fix params

* Bump utils version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants