feat: get class attribute name/values #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `get_class_attrs` logging method that can be used to get a dict of a Class, and instance, attribute name/value pairs. This will be used to dump the Config class values when Notify services start to validate they are configured as expected.
patheard
changed the title
jzbahrai
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a
get_class_attrslogging method that can be used to get adict of a Class attribute name/value pairs. This will replace
the current Config.get_config class method.
This will be used to dump the Config class values when Notify
services start to validate they are configured as expected.
Note
This PR also adds a VS Code devcontainer for local development.
Related
notification-utilsnotification-planning#522