Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No report of failed load attempt of requirements expressed with advanced version specifiers #356

Closed
xdelaruelle opened this issue Aug 13, 2020 · 0 comments
Labels
Milestone

Comments

@xdelaruelle
Copy link
Member

When a requirement in a modulefile is expressed with the advanced version specifiers syntax:

$ ml show mod/1.0
-------------------------------------------------------------------
/path/to/modulefiles/mod/1.0:

prereq          unknown@1.2,1.4
-------------------------------------------------------------------

Automated load attempt of such requirement is not correctly reported in case of failure:

$ ml --auto mod/1.0
Loading mod/1.0
  ERROR: Unable to locate a modulefile for 'unknown@1.2,1.4'
  ERROR: mod/1.0 cannot be loaded due to missing prereq.
    HINT: the following module must be loaded first: unknown@1.2,1.4

Error message should mention that the load of the requirement were attempted.

Issue only occurs when advanced_version_spec configuration is enabled. Expected error message is obtained otherwise:

$ ml --auto mod/1.0
Loading mod/1.0
  ERROR: Unable to locate a modulefile for 'unknown@1.2,1.4'
  ERROR: Load of requirement 'unknown@1.2,1.4' failed
@xdelaruelle xdelaruelle added this to the 4.5.3 milestone Aug 13, 2020
xdelaruelle added a commit to xdelaruelle/modules that referenced this issue Aug 31, 2020
Correctly report failed attempts to load module requirements expressed
with advanced version specifiers.

Fixes cea-hpc#356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant