Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successive Strongs #139

Closed
wants to merge 3 commits into from
Closed

Conversation

wogsland
Copy link
Contributor

@wogsland wogsland commented Jan 18, 2017

This allows for successive strong tags to be created without breaking any existing tests.

Fixes #111

@wogsland wogsland changed the title 111 successive strongs Successive Strongs Jan 18, 2017
@@ -12,5 +12,6 @@
<p><em>emphasized text</em><strong>strong text</strong></p>
<p><strong>strong text</strong><em>emphasized text</em></p>
<p><em>emphasized text</em><strong>strong text</strong></p>
<p><strong>strong text A</strong><strong>strong text B</strong></p>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would you do this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seemed to me to be the gist of #111, but perhaps I missed something?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I see now, thank you. Will think a bit about it. Not breaking other tests does not mean it does not break anything else, will check that out in more detail later :)

@cebe cebe added this to the 1.1.2 milestone Jan 18, 2017
@cebe cebe modified the milestones: 1.1.2, 1.1.3 Jul 16, 2017
@cebe cebe modified the milestones: 1.2.0, 1.3 Mar 14, 2018
@cebe cebe self-assigned this Mar 14, 2018
@cebe cebe closed this in 7d43c86 Mar 14, 2018
@cebe
Copy link
Owner

cebe commented Mar 14, 2018

Merged and adjusted it for underscore also. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants