Mac GUI: don't show /dev/poll/cdrom if it is configured as cdrom #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvitkine
requested changes
Feb 25, 2018
| [disk setPath:[NSString stringWithUTF8String: dsk ]]; | ||
| [disk setIsCDROM:YES]; | ||
| NSString *path = [NSString stringWithUTF8String: dsk ]; | ||
| if (![path hasPrefix:@"/dev/"]) { |
There was a problem hiding this comment.
Your indentation doesn't seem to be consistent with the rest of the file. Could you please make it consistent?
|
|
||
| // Remove all cdroms (but keep the ones in /dev/) | ||
| const char *path; | ||
| int index=0; |
| if(![p hasPrefix:@"/dev/"]) { | ||
| PrefsRemoveItem("cdrom", index); | ||
| } | ||
| else { |
There was a problem hiding this comment.
Nit: Combine with previous line.
| int index=0; | ||
| while ((path = PrefsFindString("cdrom", index)) != NULL) { | ||
| NSString *p = [NSString stringWithUTF8String: path]; | ||
| if(![p hasPrefix:@"/dev/"]) { |
|
I have fixed the formatting. |
asvitkine
reviewed
Feb 25, 2018
| const char *path; | ||
| int index = 0; | ||
| while ((path = PrefsFindString("cdrom", index)) != NULL) { | ||
| NSString *p = [NSString stringWithUTF8String: path]; |
There was a problem hiding this comment.
Nit: Indent for this line is still off.
rakslice
pushed a commit
to rakslice/macemu
that referenced
this pull request
Oct 16, 2020
Mac GUI: don't show /dev/poll/cdrom if it is configured as cdrom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #149.
It will still show the
/dev/poll/cdromentries if they are not configured as cdrom, so that the user can remove those entries.