Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Filter Dialog (especially) on Mobile #248

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

michikrug
Copy link
Contributor

Description

This PR improves the responsiveness of the filter modal on mobile browsers by only partially displaying mons in chunks of 100. The user can load the next chunks by pressing the new "Load More..." button.

Furthermore, I have changed the former approach of using the IntersectionObserver to plain lazy loading of images.

Hint: Unfortunately, this partially breaks the search functionality as only displayed items are searchable.

Motivation and Context

Currently, the huge amount of >800 mons and the corresponding amount of html nodes freezes mobile browsers when the filter dialog is opened.

How Has This Been Tested?

Own instance on desktop (OSX) and mobile (Android) Chrome.

Screenshots (if appropriate):

Bildschirmfoto 2022-03-18 um 21 46 55

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@michikrug
Copy link
Contributor Author

michikrug commented Mar 18, 2022

Question 1: shall I only enable this feature on mobile browsers as it seems to be not a problem on desktop?

Question 2: do you think it's worth looking for a possible solution to the broken search?

@na-ji
Copy link
Collaborator

na-ji commented Mar 27, 2022

Thank you for your PR.

Question 1: shall I only enable this feature on mobile browsers as it seems to be not a problem on desktop?

Having better performance should be on every device, we don't know if our users are using potatoes computers on par with a mobile device.

Question 2: do you think it's worth looking for a possible solution to the broken search?

I believe that would be mandatory, since the search is really useful. The search would require a refactor to make both those features work together. Maybe rebuilding the filter list after a search could solve this. But this might slow down the search, and this new feature might have been for nothing. 🤔

@michikrug
Copy link
Contributor Author

Thank you for your input. I will see if I can find any solution to the search....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants