[TinyTodo] Update the instruction to use Python virtual environment #140
Conversation
Signed-off-by: Shaobo He <shaobohe@amazon.com>
shaobo-he-aws
requested review from
khieta,
cdisselkoen,
aaronjeline,
andrewmwells-amazon and
john-h-kastner-aws
tinytodo/README.md
Outdated
| python3 -m venv /tmp/tinytodo | ||
| source /tmp/tinytodo/bin/activate |
There was a problem hiding this comment.
is it a good idea / best practice to put the virtual environment in tmp? I think I've previously just put the virtual environment in the current directory, but not sure if that's good or not
There was a problem hiding this comment.
From my limited python experience I would also expect the virtual env to be in the project directory
There was a problem hiding this comment.
I think python3 -m venv . is not a good idea because it creates directories like bin and lib, which kinda mess up the project directory structure. How about making a new directory like venv?
There was a problem hiding this comment.
That seems reasonable. In fact, now that you say that, I feel like I've typed python3 -m venv venv before
There was a problem hiding this comment.
yeah, that's what I assumed craig meant initially
Signed-off-by: Shaobo He <shaobohe@amazon.com>
Issue #, if available:
#139
Description of changes: