rename some types, fields, functions, and variables related to common types #1065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
On the heels of #1059, and following this comment on #1060, this PR renames a bunch of other types, fields, functions, and variables related to common types.
self.type_defs.type_defs
intoself.common_types.defs
)I believe that none of the changes here are breaking, or even visible outside the
cedar-policy-validator
crate. The field renames are in structs that don't implSerialize
orDeserialize
, and the types and functions are crate-private. Happy to be corrected if I'm wrong.Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy-core
,cedar-validator
, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec
(choose one, and delete the other options):