-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add formatting and JSON conversion utilities to ffi #1087
Conversation
/// Note that the [`Template`] type can represent both static policies and | ||
/// policy templates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good note, I had forgotten this was the case in the FFI. It's not true of cedar_policy::Template
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was wondering as I wrote this if we should update the Policy
type in the FFI to support both static policies and templates. Opinions? Should we even have a Template
type at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having Policy
in the FFI support both static policies and templates might be additionally confusing because Policy
in cedar_policy
represents both static policies and template-linked policies, but not templates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yuck. I'll leave it as-is then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made an issue #1095
Co-authored-by: Craig Disselkoen <cdiss@amazon.com>
Description of changes
cedar-wasm/
&
is a special character forsed
in some positions.PR to fix downstream breaks in wasm example: cedar-policy/cedar-examples#180
Issue #, if available
Resolves #854
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec
(choose one, and delete the other options):