Followup to #870 #910
Merged
Followup to #870 #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-h-kastner-aws
approved these changes
May 24, 2024
|
Note: downstream DRT failure is unrelated to this PR (it's due to #898) |
shaobo-he-aws
approved these changes
May 24, 2024
|
I will cherry-pick it into 3.2.x. |
shaobo-he-aws
pushed a commit
that referenced
this pull request
May 24, 2024
shaobo-he-aws
pushed a commit
that referenced
this pull request
May 28, 2024
shaobo-he-aws
added a commit
that referenced
this pull request
May 28, 2024
Signed-off-by: Shaobo He <shaobohe@amazon.com> Co-authored-by: Kesha Hietala <khieta@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Followup to #870, which did not entirely fix #862, as identified by nightly fuzzing. My bad 😅
The issue was that the regular expression for strings matched all content up until the newline after the final quotation, which might end up splitting strings. I had added the extra
[^\n]*when I was testing the original design, and forgot to remove it. The regular expression for strings now exactly matches the one used elsewhere in the formatter.Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy.I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):