Added CDRSlowTestReporter to identify slowest running tests #46
Conversation
|
Actually. Hold off on this - it breaks the install script (silly issue). Will fix and send you a new pull request soon. |
|
All better! |
|
what if we just add this to the default reporter with env var to turn it on? that way we can have color and slow tests. |
|
Sounds good to me. Shouldn't be hard as it runs at the end of the print stats section. If we do this I'd propose pulling the functionality from CDRSlowTestReporter into its own object (CDRSlowTestAnalyzer?) that takes the rootGroups and processes them and either returns or prints out its output. That way we can try to prevent the reporter from getting to bloated. If there's interest I'd be happy to work on this tomorrow. Shouldn't take long. |
|
That sounds like a good idea. As of fd68ffc even the JUnit reporter prints out stats to stdout on run completion, so if we output this as part of the stats then it will appear regardless of which reporter you've chosen. Should we overload CEDAR_REPORTER_OPTS for this setting? I noticed it is only used for the 'nested' output setting for the default reporter, but the name of the environment variable sounds like it can't wait to be a comma separated list. |
|
Given that Xcode has checkmarks for turning on/off specific env variables I think we should sunset CEDAR_REPORTER_OPTS and use separate env vars for nested format and slow examples. |
|
That sounds good to me. I'm working on pulling the slow stat reporting Onsi On Fri, Oct 5, 2012 at 8:00 PM, Dmitriy Kalinin notifications@github.comwrote:
|
|
Done. The slow stat reporting is in the default reporter now. Use the CEDAR_REPORT_SLOW_TESTS environment variable to turn it on. |
|
|
||
| @interface CDRSlowTestReporter : CDRDefaultReporter | ||
|
|
||
| @end |
There was a problem hiding this comment.
do we need this file? if not it's also inside xcode.proj.
There was a problem hiding this comment.
Nope my bad. Why are all the headers in their own folder anyway? Will remove...
On Oct 6, 2012, at 9:48 AM, Dmitriy Kalinin notifications@github.com wrote:
In Source/Headers/CDRSlowTestReporter.h:
@@ -0,0 +1,5 @@
+#import "CDRColorizedReporter.h"
+
+@interface CDRSlowTestReporter : CDRDefaultReporter
+
+@EnD
do we need this file? if not it's also inside xcode.proj.—
Reply to this email directly or view it on GitHub.
By default the top N=10 slow tests and root example groups are reported. Set CEDAR_TOP_N_SLOW_TESTS to modify N.
|
Rebased down to one commit on top of latest pivotal/cedar HEAD. |
Added CDRSlowTestReporter to identify slowest running tests
For tracker story #36037887
Lemme know if you'd like me to tweak/change/fix this in any way!