Borrar la dependencia de serviceworker-rails
#492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +0,0 @@ | |||
| if (navigator.serviceWorker) { | |||
| window.addEventListener('load', () => { | |||
| navigator.serviceWorker.register('/serviceworker.js', { scope: './' }) | |||
There was a problem hiding this comment.
tendriamos que hacer unregister del service worker q los usuarios tengan instalado?
o no es necesario?
There was a problem hiding this comment.
Fijate lo que hice en 663ec44
app/views/pwa/manifest.json.erb
Outdated
| "short_name": "MiCarrera", | ||
| "icons": [ | ||
| { | ||
| "src": "<%= asset_path('icon-192.png') %>", |
There was a problem hiding this comment.
por lo que veo, lo que hay en este momento en Rails 7.2 genera un archivo que no tiene nada dinámico (el <%= camelized %> creo que lo remplaza cuando procesa el template (.tt)).
Si es así, y esto es un archivo estático, no se puede servir desde la carpeta public/ como un asset estático?
There was a problem hiding this comment.
Buen punto!
EmilioCristalli
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hay un issue con la gema
serviceworker-railsque no anda conrackv3.1. El último commit en el repo fue hace cuatro años.Este PR saca la dependencia de
serviceworker-railsy en su lugar añade un controlador para servir los archivos necesarios para levantar una PWA (manfiest.jsonyserviceworker.js) de la misma forma que se hará en Rails 7.2.