Prevent quick edit nonces from being submitted when searching or filt…

…ering the post list table.
cedaro · Jan 30, 2014 · 8cc4f5d · 8cc4f5d
1 parent a32d423
commit 8cc4f5d
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/admin/admin.php b/admin/admin.php
@@ -219,7 +219,8 @@ public static function display_columns( $column, $page_id ) {
 			}
 
 			// Add the nonce here and copy it to the inline editor with javascript.
-			wp_nonce_field( 'update-page-sidebar_' . $page_id, 'simplepagesidebars_page_sidebar_update_nonce', false );
+			$nonce = wp_create_nonce( 'update-page-sidebar_' . $page_id );
+			printf( '<input type="hidden" value="%s" class="simplepagesidebars_page_sidebar_update_nonce">', esc_attr( $nonce ) );
 		}
 	}
 
@@ -251,6 +252,7 @@ public static function quick_edit_custom_box( $column, $post_type ) {
 							?>
 						</select>
 					</label>
+					<?php wp_nonce_field( 'update-page-sidebar', 'simplepagesidebars_page_sidebar_update_nonce', false ); ?>
 				</div>
 			</div>
 		</fieldset>
@@ -283,7 +285,8 @@ public static function quick_edit_js() {
 
 				var postId = inlineEditPost.getId( id ),
 					currentSidebar = $( '#post-' + postId + ' .simple-page-sidebar' ).text(),
-					sidebarNameField = $( '#simple-page-sidebars-page-sidebar-name' );
+					sidebarNameField = $( '#simple-page-sidebars-page-sidebar-name' ),
+					$nonceField = $( '#simple-page-sidebars-page-sidebar-edit-group' ).find( 'input[name="simplepagesidebars_page_sidebar_update_nonce"]' );
 
 				// Select the current sidebar option.
 				sidebarNameField.find( 'option' ).attr( 'selected', false );
@@ -292,9 +295,7 @@ public static function quick_edit_js() {
 				}
 
 				// Copy the sidebar name nonce.
-				$( '#simple-page-sidebars-page-sidebar-edit-group' )
-					.find( 'input[name="simplepagesidebars_page_sidebar_update_nonce"]' ).remove().end()
-					.append( $( '#post-' + postId + ' input[name="simplepagesidebars_page_sidebar_update_nonce"]' ).clone() );
+				$nonceField.val( $( '#post-' + postId + ' .simplepagesidebars_page_sidebar_update_nonce' ).val() );
 			};
 		} )( window, jQuery );
 		</script>