-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.0 of fivebeans #10
Commits on May 4, 2013
-
Begin bringing this module up to my current standards for node modules.
- main is now index.js - each submodule in lib now exports one item - fixed some small style things - added code coverage tools to the test harness Pre-bumped the version number because this will be an API-breaking release. Next up: removing logging.
Configuration menu - View commit details
-
Copy full SHA for 1748d1b - Browse repository at this point
Copy the full SHA 1748d1bView commit details -
The worker now emits 'log' events instead of attempting to log all by…
… itself. Documentation to follow in the readme once I'm happy with the format of the objects passed to the event.
Configuration menu - View commit details
-
Copy full SHA for 8883f39 - Browse repository at this point
Copy the full SHA 8883f39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34b40cb - Browse repository at this point
Copy the full SHA 34b40cbView commit details -
The client now emits errors on interesting events like connect, close…
…, and error. You are expected to listen for those events and act upon them. In particular, the API has changed to that connect no longer takes a callback. worker.start() no longer takes a flag to ignore the default tube. Instead you can set 'ignoreDefault' in the options hash you pass to the worker constructor. The worker no longer attempts to ignore the default tube if it's not watching anything else. Started implementing tests for the worker. This brings coverage up over 50% (which is pathetic, but it's a start) so I added coverage checking to the test targets run by Travis CI.
Configuration menu - View commit details
-
Copy full SHA for a5e7cc2 - Browse repository at this point
Copy the full SHA a5e7cc2View commit details
Commits on May 5, 2013
-
Configuration menu - View commit details
-
Copy full SHA for 772d470 - Browse repository at this point
Copy the full SHA 772d470View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54cfb50 - Browse repository at this point
Copy the full SHA 54cfb50View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4ce59b - Browse repository at this point
Copy the full SHA a4ce59bView commit details -
The worker is now restartable.
That is, you can call stop() and then start() on it without needing to create a new one. You'll still need to re-watch any tubes you were watching. (Going to rework that, at which point this client will be far divorced from the original project.) Implemented more worker tests. Client test coverage is now at 91% and worker coverage at 92%.
Configuration menu - View commit details
-
Copy full SHA for 6f42c30 - Browse repository at this point
Copy the full SHA 6f42c30View commit details -
Added two more worker job-handling tests.
The bad json test exposed a bug, which I fixed: we would cheerfully go on to try to use a bad job payload. Yay integration tests.
Configuration menu - View commit details
-
Copy full SHA for c81732a - Browse repository at this point
Copy the full SHA c81732aView commit details -
Travis test timings are much slower than on my MacBook.
I read that virtualization means I'm running these tests on the equivalent of a RaspberryPI, which is awesome. Anyway, try to work around the timing differences while maintaining the usefulness of the tests.
Configuration menu - View commit details
-
Copy full SHA for 8fae5cc - Browse repository at this point
Copy the full SHA 8fae5ccView commit details -
The worker emits many more events to make processing jobs a little ni…
…cer. Well, as scientifically measured, about a million times nicer. Here is a list of events emitted and some notes on what they mean. This will turn into documentation eventually: error: payload is error; cannot be recovered from close: worker got a close event from its client; no payload warning: payload is object with error information; execution continues info: the equivalent of info-level logging; payload is object with action info started: worker has started processing jobs; no payload stopped: worker has stopped processing jobs; no payload job.reserved: payload is jobid job.handled: payload is object with job info job.deleted: payload is jobid job.destroyed: payload is jobid job.buried: payload is jobid Rewrote the tests to use the events, which should make them less timing-dependent. I might still not be allowing enough slop for the slowness of TravisCI.
Configuration menu - View commit details
-
Copy full SHA for dbbd87a - Browse repository at this point
Copy the full SHA dbbd87aView commit details -
Bump up the timeout on two worker tests.
These are consistently passing for me, so perhaps it's just that the tests are running on a RaspberryPI hosted at Amazon.
Configuration menu - View commit details
-
Copy full SHA for b91fcbe - Browse repository at this point
Copy the full SHA b91fcbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for b54260f - Browse repository at this point
Copy the full SHA b54260fView commit details -
Don't test kick-job if the version of beanstalkd doesn't support it.
kick-job was introduced in 1.8 in Nov 2012. Apparently the package Travis installs is older than that. Used semver to compare versions because I am very lazy.
Configuration menu - View commit details
-
Copy full SHA for 481de1d - Browse repository at this point
Copy the full SHA 481de1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a815d6 - Browse repository at this point
Copy the full SHA 6a815d6View commit details -
You can now specify a delay of 0 when releasing jobs.
And use that in the worker release test, to completely removing timing issues from the test. This should fix Travis. Famous last words.
Configuration menu - View commit details
-
Copy full SHA for 9594702 - Browse repository at this point
Copy the full SHA 9594702View commit details -
Added basic tests for the runner.
Code coverage is now up over 90%, so I set the travis-cov threshold to 90. Next up: documentation.
Configuration menu - View commit details
-
Copy full SHA for 932d912 - Browse repository at this point
Copy the full SHA 932d912View commit details -
Configuration menu - View commit details
-
Copy full SHA for 717e519 - Browse repository at this point
Copy the full SHA 717e519View commit details -
Brought documentation up to date.
Documented the new client.connect() behavior. Documented the new worker events. Improved worker documentation overall.
Configuration menu - View commit details
-
Copy full SHA for 6312222 - Browse repository at this point
Copy the full SHA 6312222View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dc3cb3 - Browse repository at this point
Copy the full SHA 0dc3cb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94db5ea - Browse repository at this point
Copy the full SHA 94db5eaView commit details