Fix 641 - Memory leak: JavascriptRootObjectWrapper is not released on Reload #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -19,7 +19,7 @@ namespace CefSharp | |||
| JavascriptProperty^ _javascriptProperty; | |||
| int64 _ownerId; | |||
| IBrowserProcess^ _browserProcess; | |||
|
|
|||
| Object^ _javascriptObjectWrapper; | |||
There was a problem hiding this comment.
Any reason that this is of type object and not JavascriptObjectWrapper?
There was a problem hiding this comment.
I couldn't figure out how to make the compiler happy with th real type so I used object as a temporary fix.
|
@sylvain-hamel I haven't compiled the code yet, so my comments are just from reading over it. Appreciate your comments 👍 |
|
I did not plan on merging this when I commited this, which explains the state of the code. I'd really appreciate it if you could take care of finishing this change. change it in any way you want. |
|
@sylvain-hamel No problem, I'll take care of it. |
|
@amaitland Thanks a lot. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix for #641 until a better fix is found. See discussion on #641 for more detail.