m1 support #17
Merged
m1 support #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice addition! The only problem is that I don't have a M1 here to continue giving support on this... |
|
Ah, fair enough! I'd donate a runner if I had a desktop mac lol. You're welcome to ping me whenever you need an updated m1 build since it'd be a fairly infrequent task, though I'll concede that it would be a clunky process haha. |
|
Hey @aprivette, did you have any trouble running steamworks.js on M1? I just thought we had some problems with platform-specific bindings before: Noxime/steamworks-rs#106 |
|
@ceifa I'll admit I didn't test this extensively but it did work. If there's anything specific you'd like me to test I'm happy to! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Thanks for your work on this. Greenworks was giving me a headache.
I was hoping to get M1 support going here, but since github actions doesn't support that yet (outside of self hosting it seems), I wasn't sure how it would be best to handle it. This PR just basically copies the arm64 binary I built into the dist folder before publish. I will admit this solution isn't ideal, but I'm open to ideas!