Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the ability to use Debian based distributions by adding the apt-get package manager #695

Merged
merged 1 commit into from Mar 18, 2021
Merged

Conversation

stephengaito
Copy link
Contributor

@stephengaito stephengaito commented Mar 17, 2021

This pull request provides changes to (the development branch of) CEKit to allow the use of apt-get as a package manager.

These changes are based upon the corresponding pull request for the Alpine apk package manager #612 corresponding to the enhancement issue #609

Following the example of the PR #612 we have added:

  1. changes to the templating system (via template_helper.py),
  2. updated the documentation,
  3. added (minimal?) tests corresponding to the use of debian-slim and apt-get as the distribution and its package manager.

NOTE: The Debian apt-get package manager seems to require an "update" step before its "install" step. To be completely "correct" we should refactor the repo_install and pkg_install macros in the cekit/templates/template.jinja file to add an explicit "pre-install" step. However we have, for this PR, simply added update && apt-get --no-install-recommends to the package_manager_flags macro in the cekit/template_helper.py file. (see the PR differences report).

All tests pass against the Python 3.8 interpreter. (make test).

Fixes #693

@stephengaito stephengaito marked this pull request as ready for review March 17, 2021 12:18
@rnc rnc merged commit 7063df8 into cekit:develop Mar 18, 2021
@rnc
Copy link
Contributor

rnc commented Mar 18, 2021

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for APT-GET package manager
2 participants