Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cuda build instructions #1043

Merged
merged 6 commits into from
Dec 2, 2023
Merged

Update cuda build instructions #1043

merged 6 commits into from
Dec 2, 2023

Conversation

esseivaju
Copy link
Contributor

This update the instructions for building dependencies using cuda. They were out of date because the packages:all:variants within spack.yaml were overriding the user-scope config.

Also update vecgeom minimum required version to match CMake and fix a few broken links.

@esseivaju esseivaju added the core Software engineering infrastructure label Dec 1, 2023
@esseivaju esseivaju requested a review from sethrj December 1, 2023 20:01
@esseivaju esseivaju added the minor Minor internal changes or fixes label Dec 1, 2023
sethrj
sethrj approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@sethrj sethrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that Julien! Even though 11.0.3 is still the only supported geant version, could you also add that we test several other compilers in the CI?

README.md Show resolved Hide resolved
@esseivaju
Copy link
Contributor Author

Alright, should be good now assuming I didn't miss any tested compiler.

@sethrj sethrj enabled auto-merge (squash) December 2, 2023 14:18
@sethrj sethrj merged commit 8d085a6 into celeritas-project:develop Dec 2, 2023
20 checks passed
@esseivaju esseivaju deleted the doc-cuda-build branch May 29, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethrj sethrj sethrj approved these changes

Assignees
No one assigned
Labels
core Software engineering infrastructure minor Minor internal changes or fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esseivaju @sethrj