Fix celer-g4 primary generator MT reproducibility #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
approved these changes
Dec 10, 2023
| // thread across multiple runs. For reproducibility, Geant4 reseeds each | ||
| // worker thread's RNG at the start of each event with a seed calculated | ||
| // from the event ID. | ||
| rng_.seed(seed_ + event_id); |
There was a problem hiding this comment.
Currently the primary generator RNGs are all std::mt1997, but we should consider some sort of wrapper interface that lets us do seed+stride for the XORWOW generators (and any others we implement in the future)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reseeds the celer-g4 primary generator RNG for each event so MT results without Celeritas offloading are reproducible. It also fixes the check that
num_eventshave been generated (which was based on the per-thread count rather than the total count).