Fix and avoid including algorithms header for ROOT/CLING #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If ROOT touches it, it dies (missing sincospi)
```
/Users/seth/Code/celeritas-temp/src/corecel/math/Algorithms.hh:533:1: error: no member named '__sincospif' in the global namespace
CELER_WRAP_MATH_FLOAT_DBL_PTR_2(__, sincospi)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/seth/Code/celeritas-temp/src/corecel/math/Algorithms.hh:395:18: note: expanded from macro 'CELER_WRAP_MATH_FLOAT_DBL_PTR_2'
return ::PREFIX##FUNC##f(value, a, b); \
~~^
<scratch space>:206:1: note: expanded from here
__sincospif
^
In file included from input_line_9:3:
In file included from /Users/seth/Code/celeritas-temp/src/celeritas/io/ImportData.hh:25:
In file included from /Users/seth/Code/celeritas-temp/src/corecel/math/ArrayUtils.hh:17:
/Users/seth/Code/celeritas-temp/src/corecel/math/Algorithms.hh:533:1: error: no member named '__sincospi' in the global namespace
CELER_WRAP_MATH_FLOAT_DBL_PTR_2(__, sincospi)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/seth/Code/celeritas-temp/src/corecel/math/Algorithms.hh:399:18: note: expanded from macro 'CELER_WRAP_MATH_FLOAT_DBL_PTR_2'
return ::PREFIX##FUNC(value, a, b); \
~~^
<scratch space>:207:1: note: expanded from here
__sincospi
^
Error: /opt/spack/var/spack/environments/celeritas/.spack-env/view/bin/rootcling: compilation failure (/Users/seth/Code/celeritas-temp/build-clhep/lib/libceleritas0cc6355a49_dictUmbrella.h)
```
sethrj
added
core
pcanal
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
The changes actually looks like improvement even-though the work-around issue is technically in bug in Cling: root-project/root#14442
sethrj
added a commit
to sethrj/celeritas
that referenced
this pull request
Feb 5, 2024
…roject#1087) * Don't include ArrayUtils in Types * Don't rely on apple functions when using ROOT * IWYU for celeritas::forward
sethrj
added a commit
that referenced
this pull request
Feb 15, 2024
* Don't include ArrayUtils in Types * Don't rely on apple functions when using ROOT * IWYU for celeritas::forward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ROOT touches Algorithms, it fails to compile due to missing
__sincospiwhich is included by an apple header. This both removes the inclusion ofArrayUtilsinTypesand fixes the macros so that__sincospiis assumed not to exist when using ROOT.