Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and avoid including algorithms header for ROOT/CLING #1087

Merged
merged 4 commits into from
Jan 25, 2024

Commits on Jan 22, 2024

  1. Don't include ArrayUtils in Types

    If ROOT touches it, it dies (missing sincospi)
    
    ```
    /Users/seth/Code/celeritas-temp/src/corecel/math/Algorithms.hh:533:1: error: no member named '__sincospif' in the global namespace
    CELER_WRAP_MATH_FLOAT_DBL_PTR_2(__, sincospi)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    /Users/seth/Code/celeritas-temp/src/corecel/math/Algorithms.hh:395:18: note: expanded from macro 'CELER_WRAP_MATH_FLOAT_DBL_PTR_2'
            return ::PREFIX##FUNC##f(value, a, b);                               \
                   ~~^
    <scratch space>:206:1: note: expanded from here
    __sincospif
    ^
    In file included from input_line_9:3:
    In file included from /Users/seth/Code/celeritas-temp/src/celeritas/io/ImportData.hh:25:
    In file included from /Users/seth/Code/celeritas-temp/src/corecel/math/ArrayUtils.hh:17:
    /Users/seth/Code/celeritas-temp/src/corecel/math/Algorithms.hh:533:1: error: no member named '__sincospi' in the global namespace
    CELER_WRAP_MATH_FLOAT_DBL_PTR_2(__, sincospi)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    /Users/seth/Code/celeritas-temp/src/corecel/math/Algorithms.hh:399:18: note: expanded from macro 'CELER_WRAP_MATH_FLOAT_DBL_PTR_2'
            return ::PREFIX##FUNC(value, a, b);                                  \
                   ~~^
    <scratch space>:207:1: note: expanded from here
    __sincospi
    ^
    Error: /opt/spack/var/spack/environments/celeritas/.spack-env/view/bin/rootcling: compilation failure (/Users/seth/Code/celeritas-temp/build-clhep/lib/libceleritas0cc6355a49_dictUmbrella.h)
    ```
    sethrj committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    99a5ff1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7ea4b02 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Configuration menu
    Copy the full SHA
    acef5b5 View commit details
    Browse the repository at this point in the history
  2. IWYU for celeritas::forward

    sethrj committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    61afa39 View commit details
    Browse the repository at this point in the history