New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Seltzer-Berger energy distribution #204
Merged
sethrj
merged 8 commits into
celeritas-project:master
from
sethrj:sb-energy-distributions
Apr 2, 2021
Merged
Add Seltzer-Berger energy distribution #204
sethrj
merged 8 commits into
celeritas-project:master
from
sethrj:sb-energy-distributions
Apr 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation is extremely efficient when sampling tables because it calculates a very close bound for the rejection function. It should have a low number memory accesses and be cache efficient because of how the cross sections are used and intermediate values are calcualtled by the energy distribution's constructor.
stognini
reviewed
Apr 1, 2021
stognini
reviewed
Apr 1, 2021
amandalund
reviewed
Apr 1, 2021
stognini
reviewed
Apr 1, 2021
amandalund
reviewed
Apr 1, 2021
amandalund
approved these changes
Apr 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks @sethrj!
@whokion Any comments on this new bit of physics? |
whokion
reviewed
Apr 2, 2021
whokion
reviewed
Apr 2, 2021
re_electron -> r_electron lambda_compton -> labmdabar_electron
Thanks @amandalund @stognini @whokion for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work that I put in the brems-collab group but required #186 to be merged in first.