Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Seltzer-Berger energy distribution #204

Merged
merged 8 commits into from Apr 2, 2021

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Apr 1, 2021

This is work that I put in the brems-collab group but required #186 to be merged in first.

The implementation is extremely efficient when sampling tables because
it calculates a very close bound for the rejection function. It
should have a low number memory accesses and be cache efficient because
of how the cross sections are used and intermediate values are
calcualtled by the energy distribution's constructor.
@sethrj sethrj added the physics Particles, processes, and stepping algorithms label Apr 1, 2021
@sethrj sethrj added this to the Y1Q3 Goals milestone Apr 1, 2021
@sethrj sethrj added this to In progress in v0.1.0 via automation Apr 1, 2021
@sethrj sethrj modified the milestones: Y1Q3 Goals, Y1Q4 Goals Apr 2, 2021
Copy link
Contributor

@amandalund amandalund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @sethrj!

v0.1.0 automation moved this from In progress to Review in progress Apr 2, 2021
@sethrj
Copy link
Member Author

sethrj commented Apr 2, 2021

@whokion Any comments on this new bit of physics?

src/base/Constants.hh Outdated Show resolved Hide resolved
re_electron -> r_electron
lambda_compton -> labmdabar_electron
@sethrj sethrj merged commit 7498735 into celeritas-project:master Apr 2, 2021
v0.1.0 automation moved this from Review in progress to Done Apr 2, 2021
@sethrj sethrj deleted the sb-energy-distributions branch April 2, 2021 15:51
@sethrj
Copy link
Member Author

sethrj commented Apr 2, 2021

Thanks @amandalund @stognini @whokion for the reviews!

@sethrj sethrj mentioned this pull request Apr 16, 2021
6 tasks
@sethrj sethrj added the enhancement New feature or request label Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request physics Particles, processes, and stepping algorithms
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants