Load Seltzer-Berger bremsstrahlung differential cross sections and store on device #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tial cross sections Co-authored-by: Stefano Tognini <59935701+stognini@users.noreply.github.com>
- Use templated data class for SB pointers - Manage data in SB model class - Add test for SB tables Co-authored-by: Seth R. Johnson <johnsonsr@ornl.gov>
sethrj
reviewed
Mar 17, 2021
There was a problem hiding this comment.
@amandalund This looks great, thanks for breaking it apart and for you and @stognini for building up the reader and params classes and to @vrpascuzzi for setting up the initial Model files. I had to incorporate the ElementView addition into the geant-importer branch which is now merged, so you may need to merge master into this to resolve conflicts.
sethrj
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of the collaborative bremsstrahlung implementation. This part, done with @stognini and @sethrj, adds a reader for loading the SB bremsstrahlung DCS and stores the data on device through the model and templated data class (@sethrj I included your changes to the model/data here, but I can try to break it down further if you like).