Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support external installation #432

Merged
merged 10 commits into from
May 31, 2022
Merged

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented May 30, 2022

Add a CeleritasConfig.cmake file and export all the variables necessary to cleanly find_package(Celeritas) from a downstream code such as acceleritas.

@sethrj sethrj added the core Software engineering infrastructure label May 30, 2022
@sethrj sethrj requested a review from drbenmorgan May 30, 2022 13:24
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
cmake/CeleritasConfig.cmake.in Outdated Show resolved Hide resolved
Copy link
Contributor

@drbenmorgan drbenmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me now!

@sethrj sethrj merged commit 0b4c0e0 into celeritas-project:master May 31, 2022
@sethrj sethrj deleted the installation branch May 31, 2022 11:53
@sethrj
Copy link
Member Author

sethrj commented May 31, 2022

Thanks for the very useful feedback @drbenmorgan !

@sethrj sethrj added the enhancement New feature or request label Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Software engineering infrastructure enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants