-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add uniform field + MSC along-step kernel #465
Add uniform field + MSC along-step kernel #465
Conversation
This lets us use the mag field propagator for photons too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, @sethrj! Just a couple build errors and conflicts to resolve.
Were you able to run the demo loop with a uniform field?
Running TestEM3 with a 1T field along x gives an error:
😢 I'll see what might be going on. This is the first time we've ever tried to run with the field propagator outside of unit tests... |
Haha yep I just tried the same and see lots of those assertion failures (boundary action with zero mfp, all particle types)... |
@amandalund Somehow the field propagator is moving all the way to the end of the physics step but marking it as a boundary crossing. I think this is a bug in the propagator as opposed to the new code: the propagator tests are far from complete. I suggest we merge this branch (knowing that it doesn't work in anything but an infinite medium) and I rewrite the field propagator tests and fix the propagator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. Thanks @sethrj!
CI failure is due to out-of-disk for the vecgeom demos as usual. |
This implements an alternate along-step kernel for a uniform magnetic field with optional MSC. To be consistent with adept's default, this kernel doesn't implement energy fluctuations (though it would be trivial to add that capability).
Closes #281 .