Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark TDAG/CDAG generation in isolation #107

Merged
merged 8 commits into from
Mar 26, 2022
Merged

Conversation

fknorr
Copy link
Contributor

@fknorr fknorr commented Mar 12, 2022

This PR is similar to #62 in that it benchmarks various graph topologies, however, it only measures graph generation and serialization as they happen on the master node without actually passing commands on to workers. It can therefore be evaluated on a single node and timed more precisely, but does not benchmark job generation or execution at all.

  • [task-graph] benchmarks measure TDAG generation.
  • [command-graph] benchmarks measure TDAG + CDAG generation and serialization in the same thread
  • [scheduler] benchmarks are like [command-graph], but use a dedicated scheduler thread similar to the runtime

I shamelessly copied the artificial graph topologies from @PeterTh 's #62 and added real-world graph examples from wave_sim as well as an (imaginary) Jacobi solver implementation.

Benchmarking the scheduler thread required some refactoring that allows re-using its std::thread in order to exclude the thread creation overhead from timings.

@fknorr
Copy link
Contributor Author

fknorr commented Mar 16, 2022

I have simplified the implementation of benchmark tree graph generation and introduced more complex communication patterns. The correctness of the generated graphs can be verified through the [debug-graphs] test cases.

include/scheduler.h Outdated Show resolved Hide resolved
Copy link
Member

@psalz psalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! Given the precedent set by #100 this should also include updated benchmark results for ci/perf.

test/benchmarks.cc Outdated Show resolved Hide resolved
test/benchmarks.cc Outdated Show resolved Hide resolved
@fknorr fknorr merged commit 51f5bc5 into master Mar 26, 2022
@fknorr fknorr deleted the non-rt-graph-benchmarks branch July 19, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants