Skip to content

Commit

Permalink
Update celerybeat to use sh instead of bash
Browse files Browse the repository at this point in the history 
Updated the init script to work without assuming bash is always available from /bin/bash/
Also see issue #2496
  • Loading branch information
@exelian @ask
exelian authored and ask committed Feb 12, 2015
1 parent f96dbb6 commit 458d167
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion extra/generic-init.d/celerybeat
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/bin/sh -e
# =========================================================
# celerybeat - Starts the Celery periodic task scheduler.
# =========================================================
Expand Down

3 comments on commit 458d167

@jmickle
Copy link

@jmickle jmickle commented on 458d167 Oct 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes unpredictable behavior with the restart function as it loses the exit too quickly and results in the restart failing to restart celerybeat. If you are going to move away from bash rewrite the check_path check_dev_null and wait_stop function to reflect pure shell and not bash functions

@serhatbolsu
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that currently restart does not work with this implementation, also when I reboot machine, celerybeat fails to start

@serhatbolsu
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also reverting this change fixed the restart

Please sign in to comment.