Another attempt at fixing pypy tests

celery · Apr 22, 2015 · d62629f · d62629f
1 parent 97a7cc7
commit d62629f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/celery/tests/utils/test_functional.py b/celery/tests/utils/test_functional.py
@@ -79,7 +79,7 @@ def __init__(self, cache):
             def run(self):
                 while not self.__is_shutdown.isSet():
                     try:
-                        self.cache.data.popitem(last=False)
+                        self.cache.popitem(last=False)
                     except KeyError:
                         break
                 self.__is_stopped.set()

diff --git a/celery/utils/functional.py b/celery/utils/functional.py
@@ -68,6 +68,12 @@ def update(self, *args, **kwargs):
                 for item in islice(iter(data), len(data) - limit):
                     data.pop(item)
 
+    def popitem(self, last=True, _needs_lock=IS_PYPY):
+        if not _needs_lock:
+            return self.data.popitem(last)
+        with self.mutex:
+            return self.data.popitem(last)
+
     def __setitem__(self, key, value):
         # remove least recently used key.
         with self.mutex: