pr7040 introduce new bug

[uuip]

introduce new bug

or pr7040 should be

        for meta in metas:
            self.on_state_change(self._decode_result(meta), None)
        if self.subscribed_to:
            self._pubsub = self.backend.client.pubsub(
                ignore_subscribe_messages=True,
            )
            self._pubsub.subscribe(*self.subscribed_to)

2022-01-10 07:12:32,476: WARNING/MainProcess] Traceback (most recent call last):

[2022-01-10 07:12:32,477: WARNING/MainProcess]   File "src/gevent/greenlet.py", line 906, in gevent._gevent_cgreenlet.Greenlet.run

[2022-01-10 07:12:32,477: WARNING/MainProcess]   File "celery/backends/asynchronous.py", line 80, in run
    self.result_consumer.drain_events(timeout=1)

[2022-01-10 07:12:32,477: WARNING/MainProcess]   File "celery/backends/redis.py", line 153, in drain_events
    message = self._pubsub.get_message(timeout=timeout)

[2022-01-10 07:12:32,477: WARNING/MainProcess]   File "redis/client.py", line 3617, in get_message
    response = self.parse_response(block=False, timeout=timeout)

[2022-01-10 07:12:32,477: WARNING/MainProcess]   File "redis/client.py", line 3498, in parse_response
    'pubsub connection not set: '

[2022-01-10 07:12:32,477: WARNING/MainProcess] RuntimeError: pubsub connection not set: did you forget to call subscribe() or psubscribe()?

[2022-01-10 07:12:32,477: WARNING/MainProcess] 2022-01-10T07:12:32Z
[2022-01-10 07:12:32,477: WARNING/MainProcess]
[2022-01-10 07:12:32,477: WARNING/MainProcess] <Greenlet at 0x7fe38c4eec48: <bound method greenletDrainer.run of <celery.backends.asynchronous.geventDrainer object at 0x7fe38ce879e8>>> failed with RuntimeError

[auvipy]

can you confirm please @Androidown

[uuip]

I can reproduce this error.

1. root reason: Redis ResponseError: Wrong number of arguments for 'subscribe' command
2. merge pr7040
3. raise RuntimeError: pubsub connection not set. about 5 or 10 min , this err emerge.
   according to modification of pr7040, I move if self.subscribed_to to before self._pubsub =, so drain_events is ok when noting to pubsub.

@Androidown

[auvipy]

OK can you come with a PR with the proposed solution you mentioned?

[auvipy]

for meta in metas:
self.on_state_change(self._decode_result(meta), None)
if self.subscribed_to:
self._pubsub = self.backend.client.pubsub(
ignore_subscribe_messages=True,
)
self._pubsub.subscribe(*self.subscribed_to)

[thedrow]

@uuip I think it's safe to say we need an issue on this bug.

[uuip]

I made a pr 7215 just now.
but unit test failed.
so will has extra work to do ...