Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation to the task_acks_on_failure_or_timeout setting #5377

Closed
thedrow opened this issue Mar 11, 2019 · 3 comments
Closed

Add documentation to the task_acks_on_failure_or_timeout setting #5377

thedrow opened this issue Mar 11, 2019 · 3 comments
Labels
Category: Documentation Issue Type: Bug Report Priority: Blocker Severity: Low
Milestone
v4.3

Comments

@thedrow
Copy link
Member

thedrow commented Mar 11, 2019

Description

#4970 did not include the proper documentation for the setting.

Suggestions

We should ensure to document it's behaviour before 4.3 GA.
@thedrow thedrow added this to the v4.3 milestone Mar 11, 2019
@thedrow thedrow mentioned this issue Mar 11, 2019
Closed
@huangsam huangsam mentioned this issue Mar 11, 2019
Merged
@huangsam
Copy link
Contributor

@thedrow I submitted a PR based on the missing gaps I inferred from source code that used the task_acks_on_failure_or_timeout setting. I assume that the docs are built from the celery.app.task module so I applied my changes there.

@thedrow
Copy link
Member Author

thedrow commented Mar 12, 2019 •
edited
Loading

The configuration documentation is at https://github.com/celery/celery/blob/master/docs/userguide/configuration.rst.
I'll copy what you added there.

@thedrow
Copy link
Member Author

thedrow commented Mar 12, 2019

Oh, seems like this was not introduced as a setting as well.
I'm going to do so now.

thedrow added a commit that referenced this issue Mar 12, 2019
@thedrow
Added acks_on_failure_or_timeout as a setting.
e6ca997 
Fixes #5377.
@thedrow thedrow mentioned this issue Mar 12, 2019
Merged
auvipy pushed a commit that referenced this issue Mar 12, 2019
@thedrow @auvipy
Added acks_on_failure_or_timeout as a setting. (#5382)
93afcb4 
Fixes #5377.
jeyrce pushed a commit to jeyrce/celery that referenced this issue Aug 25, 2021
@thedrow @jeyrce
Added acks_on_failure_or_timeout as a setting. (celery#5382)
5431c87 
Fixes celery#5377.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Documentation Issue Type: Bug Report Priority: Blocker Severity: Low
Projects
None yet
Milestone
v4.3
Development

No branches or pull requests
2 participants
@thedrow @huangsam