Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Celery 4.3.0rc2 is not python 2.7 compatible #5383

Closed
glestel opened this issue Mar 12, 2019 · 1 comment
Closed

Celery 4.3.0rc2 is not python 2.7 compatible #5383

glestel opened this issue Mar 12, 2019 · 1 comment
Labels
Component: CLI Issue Type: Bug Report Priority: Blocker Severity: Trivial
Milestone
v4.3

Comments

@glestel
Copy link

glestel commented Mar 12, 2019

Hello,

Using celery-4.3.0rc2-py2.7 I have an exception on the file base.py because of ModuleNotFoundError that doesn't exist in python 2.7

File "/usr/local/lib/python2.7/dist-packages/celery-4.3.0rc2-py2.7.egg/celery/bin/base.py", line 285, in execute_from_commandline
     except ModuleNotFoundError as e:
 NameError: global name 'ModuleNotFoundError' is not defined

This was introduced with commit acd6025

Best regards, and thanks for the work

Guillaume
@georgepsarakis
Copy link
Contributor

Nice catch! Indeed this exception was added in 3.6.

@georgepsarakis georgepsarakis mentioned this issue Mar 12, 2019
Closed
@thedrow thedrow modified the milestones: 4.3.x Maintenance , v4.3 Mar 13, 2019
@thedrow thedrow mentioned this issue Mar 13, 2019
Open
2 tasks
jeyrce pushed a commit to jeyrce/celery that referenced this issue Aug 25, 2021
@thedrow @jeyrce
Fall back to ImportError on Python < 3.6.
52ba859 
ModuleNotFoundError was introduced in Python 3.6.
acd6025 broke support for anything below that version.

This commit fixes it.

Fixes celery#5383.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: CLI Issue Type: Bug Report Priority: Blocker Severity: Trivial
Projects
None yet
Milestone
v4.3
Development

No branches or pull requests
3 participants
@thedrow @georgepsarakis @glestel