Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include args in Received (like Rejected) #6885

Closed
4 tasks done
daveisfera opened this issue Jul 30, 2021 · 1 comment · Fixed by #6898
Closed
4 tasks done

Include args in Received (like Rejected) #6885

daveisfera opened this issue Jul 30, 2021 · 1 comment · Fixed by #6898

Comments

@daveisfera
Copy link
Contributor

  • I have checked the issues list
    for similar or identical enhancement to an existing feature.
  • I have checked the pull requests list
    for existing proposed enhancements.
  • I have checked the commit log
    to find out if the if the same enhancement was already implemented in the
    master branch.
  • I have included all related issues and possible duplicate issues in this issue
    (If there are none, check this box anyway).

Related Issues and Possible Duplicates

None that I'm aware of

Brief Summary

Logging args is really helpful, but it's currently only done with Rejected logs and it would be nice to also include in Received logs

See

'args': sargs,

Design

Architectural Considerations

If a task takes a lot of args or large args, then it could make logs large

Proposed Behavior

Include args in Received logs

Proposed UI/UX

On by default with a way to turn it off

Diagrams

N/A

Alternatives

Off by default with a way to turn it on

@open-collective-bot
Copy link

Hey @daveisfera 👋,
Thank you for opening an issue. We will get back to you as soon as we can.
Also, check out our Open Collective and consider backing us - every little helps!

We also offer priority support for our sponsors.
If you require immediate assistance please consider sponsoring us.

thedrow pushed a commit that referenced this issue Aug 17, 2021
* Add args and kwargs to LOG_RECEIVED and LOG_SUCCESS

* Add kwargs and args to test
jeyrce pushed a commit to jeyrce/celery that referenced this issue Aug 25, 2021
* Add args and kwargs to LOG_RECEIVED and LOG_SUCCESS

* Add kwargs and args to test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant