Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note about chord and result backend #1864

Merged
merged 1 commit into from Feb 10, 2014

Conversation

hrbonz
Copy link
Contributor

@hrbonz hrbonz commented Feb 10, 2014

Added a note at the beginning of the chord to point at the necessity to enable result backend for tasks inside a chord.

Proof of stupidity/lack of clarity in the docs/RTFM: #1857

ask added a commit that referenced this pull request Feb 10, 2014
docs: add note about chord and result backend
@ask ask merged commit 7d71a23 into celery:master Feb 10, 2014
@ask
Copy link
Contributor

ask commented Feb 10, 2014

Thanks! It could also be an idea to raise an exception if any of the tasks in a chord has ignore_result=True.

For 3.2 I want result to be stored on a task invocation basis so that you can call task.apply_async(reply='redis://localhost') so that the caller can specify if the state is required or not, and that way chord can ignore the setting and just make it work anyway.

@hrbonz
Copy link
Contributor Author

hrbonz commented Feb 10, 2014

I was thinking about it this afternoon, it would be great to be able to pass ignore_result to apply_async() or in subtask(). I'm sure there is a good reason for that behaviour, I'm still not comfortable with the source.

On another note, I found the chord / head / body a bit unintuitive, I guess head / callback is easier to understand. There are also places where callback is used and others where body is used. I wanted to rewrite some of the chord bit to make it that way.

@ask
Copy link
Contributor

ask commented Feb 10, 2014

@hrbonz
Copy link
Contributor Author

hrbonz commented Feb 11, 2014

Doesn't mean it's the best or easiest way to name those 😄
I'll propose a PR to make the canvas page a bit easier for newcomers, it took me a bit of time to get it properly.

@floer32
Copy link
Contributor

floer32 commented Oct 27, 2014

👍 this confused me as well. (Admitted beginner.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants