Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongodb default options removed. #2580

Merged
merged 3 commits into from Apr 17, 2015
Merged

Conversation

fatihsucu
Copy link
Contributor

Fixes #2579

@coveralls
Copy link

coveralls commented Apr 16, 2015

Coverage Status

Coverage increased (+0.006%) to 90.284% when pulling 772bcb8 on fatihsucu:hotfix_for_pymongo into 0cfacb7 on celery:master.

@thedrow
Copy link
Member

thedrow commented Apr 16, 2015

I think that this code should branch based on PyMongo's version.
If it's version 3 and above don't set the defaults.

@PMickael
Copy link
Member

I think, It would be better to treat the exception !

@ionelmc
Copy link
Contributor

ionelmc commented Apr 16, 2015

Turns out max_pool_size was renamed to maxPoolSize. The other option is removed in 3.0 (it had something to do with read-after-write preference, see https://github.com/mongodb/mongo-python-driver/blob/master/doc/changelog.rst#classpymongomongo_clientmongoclient-changes )

@fatihsucu will you update the PR to have version check and only set maxPoolSize on 3.0 ?

@fatihsucu
Copy link
Contributor Author

Yes, i will @ionelmc

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 90.27% when pulling e53e170 on fatihsucu:hotfix_for_pymongo into 0cfacb7 on celery:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 90.27% when pulling c0b366d on fatihsucu:hotfix_for_pymongo into 0cfacb7 on celery:master.

@PMickael
Copy link
Member

Great thanks.
Add you're name to contributor if you want.

PMickael added a commit that referenced this pull request Apr 17, 2015
Mongodb default options update in 3.0
@PMickael PMickael merged commit 580ce0e into celery:master Apr 17, 2015
@fatihsucu
Copy link
Contributor Author

Thanks for comments and advice. It would be great.

ask added a commit that referenced this pull request Apr 22, 2015
@ask
Copy link
Contributor

ask commented Apr 22, 2015

Wow, these mongo folks sure love pointless and backward incompatible changes ;)

@ask
Copy link
Contributor

ask commented Apr 22, 2015

Also applied to 3.1

tristan0x pushed a commit to cogniteev/celery that referenced this pull request Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pymongo refuses backend/mongodb.py default settings
6 participants