Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongo decode result (fixes #2458) #2591

Closed
wants to merge 1 commit into from

Conversation

buckensl
Copy link

Decode result and convert serialized exception to Python exception
fixes #2458

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 90.26% when pulling 91948ef on buckensl:mongo-result-decode into db2caf5 on celery:master.

@thedrow
Copy link
Member

thedrow commented Jun 16, 2015

Sorry for the late response.
This needs a test that verifies that the fix works.

@ask
Copy link
Contributor

ask commented Dec 11, 2015

I don't get it, why would obj["result"] contain yet another level of meta["status"], etc?

The structure is usually:
{'status': 'FAILURE', 'result': exception}

not:
{'status': 'FAILURE', 'result': {'status': FAILURE, 'result': exception}}

@ask
Copy link
Contributor

ask commented Jun 29, 2016

This has been open for too long without a resolution :( We need to be faster at merging these in the future, but need to make sure all pull requests have tests first.

@ask ask closed this Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError when executing chain.get() and group.get() (exceptions must be old-style classes)
4 participants