New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New cassandra backend #2782
New cassandra backend #2782
Conversation
module :mod:`cassandra` is not available. | ||
|
||
""" | ||
servers = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, avoid mutable class-level objects. IMO we don't need all these connection-related parameters on class level.
Added headers arg to apply_async docs to fix #2750
Can you please rebase? |
%s are here to stay - I'll need them later for Cassandra queries. I have no idea how to use celery.five to detect Python version.
…cassandra-backend Conflicts: CONTRIBUTORS.txt
Rebased all right. |
Just curious if there's any sort of timeline on getting this into Celery? We're looking to use it in a new project that's ramping up right now (Celery with Cassandra results storage, but on Python 3 so pycassa isn't an option). |
I'll speak with @ask about it first but it looks good. |
How about we keep it as |
Good work! Tested it and it seems to work. Merged into master |
@ask That would kinda break semantic versioning that I think we should adopt. |
Fantastic! Thanks for merging this folks! Any idea when the next release will be that will contain this? |
@egon1024 Sorry, we don't yet. Unfortunately we have some pretty critical bugs to resolve before we release a new major version. |
No worries - keep up the great work, it's very much appreciated. :) |
@thedrow 3.2 should probably be 4.0 at this point. semantic versioning is good, but adding experimental features to point releases can be useful, but only |
If it's 4.0 then we can rename the backend. Yes. |
@ask @piotrmaslanka My team is looking to use Cassandra for our Celery backend, but I'm not sure if our timeline matches for when this feature becomes stable, so I am looking to patch up our local mirror of Celery with this feature. What are the steps that I should take about doing that? I also don't see any code diff in this PR that would enable new Cassandra backend. |
@davidharrigan I guess |
Awesome, thanks for the quick response :D |
@davidharrigan There was a small revolution in the master - old cassandra is no more. Please be aware of that, and repatch against #2901. I rebased it for simpler inclusion. |
As per #2669 this is a Cassandra backend using DataStax python-driver.
For compatibility reasons it's called new_cassandra, and not cassandra. Configuration options also differ, mainly to force users to understand that it's a different thing.
Using old cassandra backend will raise a deprecation warning.
Schema is different from Thrift one. Assuming keyspace exists, column family will be created by default (fixes #1763).