Use correct namespace when FQN are given #3218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Celery multi is using `name` to determine namespace which won't work when FQN are given. First check if FQN namespace is available and pick options from it.
Current coverage is 95.13%@@ master #3218 diff @@
==========================================
Files 232 232
Lines 32427 32436 +9
Methods 0 0
Messages 0 0
Branches 2319 2320 +1
==========================================
+ Hits 30848 30857 +9
Misses 1363 1363
Partials 216 216
|
|
Thanks! Merged into master. Please add your name to https://github.com/celery/celery/edit/master/CONTRIBUTORS.txt |
|
Thanks. Submitted #3265 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Celery multi is using
nameto determine namespace which won't workwhen FQN are given. First check if FQN namespace is available and pick
options from it.
closes #3211