Fix celery issues when using flower REST API #3950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonastl
added a commit
to tomologic/docker-flower
that referenced
this pull request
Apr 7, 2017
Flower throws a stack trace and returns HTTP 500 when the /tasks endpoint is being triggered. A defect that manifested after Celery went from v3 to v4. The following change is incorporated celery/celery#3950 To address the following issue: mher/flower#648
jonastl
added a commit
to tomologic/docker-flower
that referenced
this pull request
Apr 7, 2017
Flower throws a stack trace and returns HTTP 500 when the /tasks endpoint is being triggered. A defect that manifested after Celery went from v3 to v4. The following change is incorporated celery/celery#3950 To address the following issue: mher/flower#648
thedrow
requested changes
Apr 9, 2017
celery/events/state.py
Outdated
| @@ -296,7 +296,7 @@ def __init__(self, uuid=None, cluster_state=None, children=None, **kwargs): | |||
| self.children = WeakSet( | |||
| self.cluster_state.tasks.get(task_id) | |||
| for task_id in children or () | |||
| if task_id in self.cluster_state.tasks | |||
| if self.cluster_state is not None and task_id in self.cluster_state.tasks | |||
There was a problem hiding this comment.
It looks like it's a better idea to extract the additional condition outside of the comprehension.
|
Thanx for your feedback @thedrow. |
|
Thanks. Feel free to add yourself to the AUTHORS file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We meet issues when using the "official" flower REST API and "broker" in front of celery.
c.f github.com/mher/flower/issues/648
I've created a Quick & Dirty patch for this.
Could you please review ?
Thanks