Prefer https over http when available #3966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedrow
requested changes
Apr 15, 2017
celery/utils/dispatch/LICENSE.python
Outdated
| @@ -184,7 +184,7 @@ conditions in CNRI's License Agreement. This Agreement together with | |||
| Python 1.6.1 may be located on the Internet using the following | |||
| unique, persistent identifier (known as a handle): 1895.22/1013. This | |||
| Agreement may also be obtained from a proxy server on the Internet | |||
| using the following URL: http://hdl.handle.net/1895.22/1013". | |||
| using the following URL: https://hdl.handle.net/1895.22/1013". | |||
There was a problem hiding this comment.
I don't think we need to change this file.
celery/utils/iso8601.py
Outdated
| @@ -1,7 +1,7 @@ | |||
| """Parse ISO8601 dates. | |||
|
|
|||
| Originally taken from :pypi:`pyiso8601` | |||
| (http://code.google.com/p/pyiso8601/) | |||
| (https://code.google.com/p/pyiso8601/) | |||
There was a problem hiding this comment.
While we're at it can you update the link? https://bitbucket.org/micktwomey/pyiso8601
|
Thanks for the review. I have integrated the feedback. |
thedrow
pushed a commit
to staticfox/celery
that referenced
this pull request
Jul 6, 2017
SebastianBerchtold
pushed a commit
to smartlane/celery
that referenced
this pull request
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.