-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support chords with empty headers #4443
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -251,15 +251,13 @@ def _unpack_chord_result(self, tup, decode, | |
raise ChordError('Dependency {0} raised {1!r}'.format(tid, retval)) | ||
return retval | ||
|
||
def apply_chord(self, header, partial_args, group_id, body, | ||
result=None, options={}, **kwargs): | ||
def apply_chord(self, header_result, body, **kwargs): | ||
# Overrides this to avoid calling GroupResult.save | ||
# pylint: disable=method-hidden | ||
# Note that KeyValueStoreBackend.__init__ sets self.apply_chord | ||
# if the implements_incr attr is set. Redis backend doesn't set | ||
# this flag. | ||
options['task_id'] = group_id | ||
return header(*partial_args, **options or {}) | ||
pass | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we sure this applies for all cases? That code is there for a reason. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep - |
||
|
||
def on_chord_part_return(self, request, state, result, | ||
propagate=None, **kwargs): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure this won't break anyone's code?